hack: stop extraction at footer in moby-sync-release.sh#24468
Open
Himanshu2459 wants to merge 1 commit intodocker:mainfrom
Open
hack: stop extraction at footer in moby-sync-release.sh#24468Himanshu2459 wants to merge 1 commit intodocker:mainfrom
Himanshu2459 wants to merge 1 commit intodocker:mainfrom
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Curious, what's your use case for this script? |
Author
|
I don't use this script myself — I spotted #24533 and traced the 404 to the autogenerated footer not being stripped during extraction. This just adds a sed to cut everything from --- onwards so only the actual notes get pulled in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues or tickets
Reviews